Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21080#discussion_r181953816
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -575,7 +575,7 @@ class CodegenContext {
         if (freshNameIds.contains(fullName)) {
           val id = freshNameIds(fullName)
           freshNameIds(fullName) = id + 1
    -      s"$fullName$id"
    +      s"${fullName}_$id"
         } else {
           freshNameIds += fullName -> 1
           fullName
    --- End diff --
    
    Hmm, doesn't it be
    
    `a_1` -> `a_1_0`
    `a` -> `a_0`
    `a` -> `a_1`
    
    ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to