Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21080#discussion_r181949672
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -575,7 +575,7 @@ class CodegenContext {
         if (freshNameIds.contains(fullName)) {
           val id = freshNameIds(fullName)
           freshNameIds(fullName) = id + 1
    -      s"$fullName$id"
    +      s"${fullName}_$id"
         } else {
           freshNameIds += fullName -> 1
           fullName
    --- End diff --
    
    If I am correct, does this still have a conflict between `a_01` wth 
`a_0$id` where `$id = 1`? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to