Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r182028213
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,10 +575,10 @@ class CodegenContext {
if (freshNameIds.contains(fullName)) {
--- End diff --
now we don't need this if
```
val id = freshNameIds.getOrElse(fullName, 0)
val res = s"${fullName}_$id"
freshNameIds(fullName) = id + 1
res
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
