Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21133#discussion_r184838245
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ApproximatePercentileQuerySuite.scala
---
@@ -279,4 +282,11 @@ class ApproximatePercentileQuerySuite extends
QueryTest with SharedSQLContext {
checkAnswer(query, expected)
}
}
+
+ test("SPARK-24013: unneeded compress can cause performance issues with
sorted input") {
+ failAfter(30 seconds) {
--- End diff --
this test looks pretty weird. Can we add some kind of unit test and move
this test to PR description and say the perf has improved a lot after this
patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
