Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21133#discussion_r184866957
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/ApproximatePercentileQuerySuite.scala
 ---
    @@ -279,4 +282,11 @@ class ApproximatePercentileQuerySuite extends 
QueryTest with SharedSQLContext {
           checkAnswer(query, expected)
         }
       }
    +
    +  test("SPARK-24013: unneeded compress can cause performance issues with 
sorted input") {
    +    failAfter(30 seconds) {
    --- End diff --
    
    I agree that this is not the best UT, but I couldn't find any better way to 
test this. If anybody has any idea of a better test, I am happy to follow your 
right suggestion...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to