Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21619#discussion_r197801381
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -148,14 +149,17 @@ trait Block extends JavaCode {
}
// Concatenates this block with other block.
- def + (other: Block): Block
+ def + (other: Block): Block = other match {
--- End diff --
I think the tree structure itself is an important information in the
generated code, we should think carefully about what a tree node means. For
example, when we want to split the code into methods, how shall we deal with
the tree node? Shall we split an entire tree node into one method? What's our
assumption to the java code inside one tree node?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
