Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21619#discussion_r197611766
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -148,14 +149,17 @@ trait Block extends JavaCode {
}
// Concatenates this block with other block.
- def + (other: Block): Block
+ def + (other: Block): Block = other match {
+ case EmptyBlock => this
+ case _ => code"$this\n$other"
--- End diff --
The concatenation of two blocks needs a newline between them like following:
[block1]
[block2]
In embedding case, like code"$block1 ... $block2", no extra newlines are
added.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
