Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21619#discussion_r197612970 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -148,14 +149,17 @@ trait Block extends JavaCode { } // Concatenates this block with other block. - def + (other: Block): Block + def + (other: Block): Block = other match { + case EmptyBlock => this --- End diff -- I had a idea to early expand `EmptyBlock` before. Now I commit it into. Then both concatenation and embedding cases, `EmptyBlock` won't be kept in arguments to code block.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org