Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3053#discussion_r19714058
  
    --- Diff: core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala 
---
    @@ -28,7 +28,7 @@ import org.apache.spark.shuffle.FetchFailedException
     import org.apache.spark.storage.BlockManagerId
     import org.apache.spark.util.AkkaUtils
     
    -class MapOutputTrackerSuite extends FunSuite with LocalSparkContext {
    +class MapOutputTrackerSuite extends FunSuite {
    --- End diff --
    
    Since the shutdown code isn't in a `try-finally` block or `after()` 
function, I guess it's still possible that it won't be called when tests fail.  
So, one test failure still might trigger spurious failures of later tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to