Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3053#discussion_r19714558
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -491,17 +491,16 @@ class StreamingContext private[streaming] (
// or context is stopped before starting
if (state == Initialized) {
logWarning("StreamingContext has not been started yet")
- return
- }
- if (state == Stopped) {
+ } else if (state == Stopped) {
--- End diff --
The intention here was that if a streamingContext has not been started,
then calling stop on it should be a noop. This change changes the start-stop
semantics of the streamingContext, and is a breaking change for downstream
systems. This is a bad idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
