Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3053#discussion_r19714794
  
    --- Diff: core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala 
---
    @@ -28,7 +28,7 @@ import org.apache.spark.shuffle.FetchFailedException
     import org.apache.spark.storage.BlockManagerId
     import org.apache.spark.util.AkkaUtils
     
    -class MapOutputTrackerSuite extends FunSuite with LocalSparkContext {
    +class MapOutputTrackerSuite extends FunSuite {
    --- End diff --
    
    Yeah, either would be better, but since each test creates a different set 
of things, and sometimes calling stop() throws an exception, I decided to just 
do it in the non-failing case for this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to