Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21352#discussion_r202902862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3226,7 +3218,7 @@ case class ArrayDistinct(child: Expression)
override def dataType: DataType = child.dataType
- @transient lazy val elementType: DataType =
dataType.asInstanceOf[ArrayType].elementType
+ private def elementType: DataType =
dataType.asInstanceOf[ArrayType].elementType
--- End diff --
+1. If it's used in `eval`, let's use lazy val, as it will be called for
every input. Are there more places like this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
