Github user mn-mikke commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21352#discussion_r203017442
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ---
    @@ -737,21 +733,22 @@ case class MapConcat(children: Seq[Expression]) 
extends ComplexTypeMergingExpres
       since = "2.4.0")
     case class MapFromEntries(child: Expression) extends UnaryExpression {
     
    -  @transient
    -  private lazy val dataTypeDetails: Option[(MapType, Boolean, Boolean)] = 
child.dataType match {
    -    case ArrayType(
    -      StructType(Array(
    -        StructField(_, keyType, keyNullable, _),
    -        StructField(_, valueType, valueNullable, _))),
    -      containsNull) => Some((MapType(keyType, valueType, valueNullable), 
keyNullable, containsNull))
    -    case _ => None
    +  @transient private lazy val dataTypeDetails: Option[(MapType, Boolean, 
Boolean)] = {
    +    child.dataType match {
    +      case ArrayType(
    +        StructType(Array(
    +          StructField(_, kt, kn, _),
    --- End diff --
    
    the motivation is described 
[here](https://github.com/apache/spark/pull/21352/files#r202983734). I will 
revert this piece of code shortly.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to