Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21352#discussion_r202984326
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -737,21 +733,22 @@ case class MapConcat(children: Seq[Expression])
extends ComplexTypeMergingExpres
since = "2.4.0")
case class MapFromEntries(child: Expression) extends UnaryExpression {
- @transient
- private lazy val dataTypeDetails: Option[(MapType, Boolean, Boolean)] =
child.dataType match {
- case ArrayType(
- StructType(Array(
- StructField(_, keyType, keyNullable, _),
- StructField(_, valueType, valueNullable, _))),
- containsNull) => Some((MapType(keyType, valueType, valueNullable),
keyNullable, containsNull))
- case _ => None
+ @transient private lazy val dataTypeDetails: Option[(MapType, Boolean,
Boolean)] = {
--- End diff --
I see, but this seems an unneeded change to me and I think there are other
places where we use this syntax, so I see no reason to change it
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
