Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/3103#discussion_r19930730
--- Diff: assembly/pom.xml ---
@@ -43,12 +43,7 @@
</properties>
<dependencies>
- <!-- Promote Guava to compile scope in this module so it's included
while shading. -->
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- <scope>compile</scope>
- </dependency>
+ <!-- Note: place this first to ensure the proper MANIFEST.MF-->
--- End diff --
Hi, @srowen, if we exclude MANIFEST.MF from deps entirely, there will be no
MANIFEST.MF in assembly jar. I failed to find a way to add MANIFEST.MF in shade
plugin(assembly jar), it seems we can only set manifestEntries but can not
create a new MANIFEST.MF in shade plugin.
And another issue is that if we exclude MANIFEST.MF but set
manifestEntries, then the excluding will be invalid.
see https://github.com/apache/spark/pull/3103#issuecomment-61904203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
