Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3103#discussion_r19930826
--- Diff: assembly/pom.xml ---
@@ -43,12 +43,7 @@
</properties>
<dependencies>
- <!-- Promote Guava to compile scope in this module so it's included
while shading. -->
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- <scope>compile</scope>
- </dependency>
+ <!-- Note: place this first to ensure the proper MANIFEST.MF-->
--- End diff --
No MANIFEST.MF file isn't a problem per se, if we don't want it to contain
anything anyway. Why not exclude MANIFEST.MF and also set entries you want? I
don't see that option tried. but, the latter is really optional. You don't even
need MANIFEST.MF at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
