Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r209712159
--- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala
---
@@ -180,6 +180,26 @@ private[spark] abstract class MemoryManager(
onHeapStorageMemoryPool.memoryUsed +
offHeapStorageMemoryPool.memoryUsed
}
+ /**
+ * On heap execution memory currently in use, in bytes.
+ */
+ final def onHeapExecutionMemoryUsed: Long =
onHeapExecutionMemoryPool.memoryUsed
--- End diff --
It probably should be if only because the variable is annotated with
`@GuardedBy(this)`, so it makes the code more consistent to mark this as
synchronized.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
