Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21221#discussion_r209715001
  
    --- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala 
---
    @@ -180,6 +180,26 @@ private[spark] abstract class MemoryManager(
         onHeapStorageMemoryPool.memoryUsed + 
offHeapStorageMemoryPool.memoryUsed
       }
     
    +  /**
    +   *  On heap execution memory currently in use, in bytes.
    +   */
    +  final def onHeapExecutionMemoryUsed: Long = 
onHeapExecutionMemoryPool.memoryUsed
    +
    +  /**
    +   *  Off heap execution memory currently in use, in bytes.
    +   */
    +  final def offHeapExecutionMemoryUsed: Long = 
offHeapExecutionMemoryPool.memoryUsed
    --- End diff --
    
    `synchronized` here also and in the below two methods.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to