Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21221#discussion_r209716819
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
    @@ -669,6 +686,31 @@ private[spark] class AppStatusListener(
             }
           }
         }
    +
    +    // check if there is a new peak value for any of the executor level 
memory metrics
    +    // for the live UI. SparkListenerExecutorMetricsUpdate events are only 
processed
    +    // for the live UI.
    +    event.executorUpdates.foreach { updates: ExecutorMetrics =>
    --- End diff --
    
    Does the type need to be explicitly defined here and in the next line?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to