Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22071#discussion_r209714362
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcher.scala
---
@@ -51,6 +51,13 @@ private[mesos] class MesosClusterDispatcher(
conf: SparkConf)
extends Logging {
+ {
+ val authKey = SecurityManager.SPARK_AUTH_SECRET_CONF
--- End diff --
Got it, my reasoning is that it could be harder for someone looking at the
code to figure out why this is not allowed, since we don't really mention about
the rest server which is really the one requiring security to be turned off.
Another reason it will be beneficial to have the check in the MesosRestServer
is that the MesosClusterDispatcher framework could technically be decoupled
from the MesosRestServer and allow another way to receive requests, so to
increase flexibility and avoid someone forgetting about why we put this here,
my suggestion is to move the check closer to where it's being required will
help maintain this a bit better.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
