Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22071#discussion_r209747074
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcher.scala
 ---
    @@ -51,6 +51,13 @@ private[mesos] class MesosClusterDispatcher(
         conf: SparkConf)
       extends Logging {
     
    +  {
    +    val authKey = SecurityManager.SPARK_AUTH_SECRET_CONF
    --- End diff --
    
    > MesosClusterDispatcher framework could technically be decoupled from the 
MesosRestServer
    
    I actually think that is a reason to keep it here.  If somebody adds 
another way, then this check is still in place for the new way -- unless they 
consciously think about making it work, and then they'd move the check to a 
more appropriate spot.
    
    I can add a comment in the code: `// This doesn't support authentication 
because the RestSubmissionServer doesn't support it.`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to