Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22071#discussion_r209743225
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcher.scala
 ---
    @@ -51,6 +51,13 @@ private[mesos] class MesosClusterDispatcher(
         conf: SparkConf)
       extends Logging {
     
    +  {
    +    val authKey = SecurityManager.SPARK_AUTH_SECRET_CONF
    --- End diff --
    
    Personally the way I read this, I agree with @squito and it should be here. 
From my understanding from reading the docs on running on mesos, the user 
doesn't start the rest server, they start the dispatcher. The dispatcher 
doesn't support any sort of authentication.  The fact that it uses the rest 
server is an implementation detail the user doesn't necessarily care about.  If 
you change the dispatcher to have another way then it should support 
authentication as well or have this same error. Someone adding another way 
other then rest server should be made aware of this, so it being here 
accomplishes that.
    
    Perhaps just adding a comment in the code about the rest server would help 
to clarify to developers?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to