Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3158#issuecomment-62353887
Hey @culler, I noticed that a significant part of the this PR is about
changing `a === b` to `EQ(a).===(b)`. I understand that this is used to avoid
function name collision between ScalaTest `===` and the newly introduced `===`
DSL operator for `Date` and `Timestamp`, but unfortunately this change is not
acceptable for several reasons:
1. `EQ(a).===(b)` looks too cumbersome, and looses all the meaning about
DSL operators -- conciseness and readability.
1. The `===` name collision problem had already been solved once when
`org.apache.spark.sql.catalyst.dsl.===` is introduced, and it has been proven
to be easy to workaround without such significant change.
1. These changes introduce unnecessary merge conflicts for other developers.
So my suggestion is that, to workaround this issue. You may add your tests
in `DslQuerySuite` with the help of `checkAnswer`, and simply don't use both
`===` within a same scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
