Github user culler commented on a diff in the pull request:
https://github.com/apache/spark/pull/3158#discussion_r20080979
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificMutableRow.scala
---
@@ -169,6 +170,35 @@ final class MutableByte extends MutableValue {
newCopy.asInstanceOf[this.type]
}
}
+final class MutableDate extends MutableValue {
--- End diff --
Thanks @liancheng, I was wondering about that. I will remove them.
On Mon, Nov 10, 2014 at 2:09 AM, Cheng Lian <[email protected]>
wrote:
> In
>
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificMutableRow.scala:
>
> > @@ -169,6 +170,35 @@ final class MutableByte extends MutableValue {
> > newCopy.asInstanceOf[this.type]
> > }
> > }
> > +final class MutableDate extends MutableValue {
>
> According to our discussion here
> <https://github.com/apache/spark/pull/3066#discussion_r19784664>, these
> two classes are not necessary.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/3158/files#r20070128>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
