Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3158#issuecomment-62406457
@culler Thanks a lot for the detailed explanation, now I believe I really
get it :)
Personally I enjoy DSL as long as they don't introduce confusion or tricky
problems (like the `===` implicit conversion). In the case of this PR, the
`RichDate` and `RichTimestamp` part looks good to me, but now I feel
complicated about the LHS literal DSL part. Especially, developers don't need
to pay much cost to workaround this issue. For example, people can always use
either `Literal(0) < 'x` or `'x > 0` to replace `0 < 'x`.
So my personal suggestion is only retaining the `Date` and `Timestamp` part
in this PR, and either remove the LHS literal part or leave it to another PR if
we can find a pleasant way to add it. In this way, this PR could be fairly
clean and understandable. @marmbrus Any comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
