Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22192#discussion_r213106129
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -130,6 +130,16 @@ private[spark] class Executor(
private val urlClassLoader = createClassLoader()
private val replClassLoader = addReplClassLoaderIfNeeded(urlClassLoader)
+ // One thread will handle loading all of the plugins on this executor
--- End diff --
I suggested an `init` method in another comment already, and I think that
should be enough, if coupled with documentation saying that method is calling
inline with the initialization of the executor, and should avoid blocking it,
doing any expensive initialization asynchronously.
We could try to be fancy and add both "init()" and "initAsync" or something
to make it easier for plugin writers, but that sounds like a small gain for the
extra complexity in the interface.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
