Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22192#discussion_r213142394
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -130,6 +130,16 @@ private[spark] class Executor(
private val urlClassLoader = createClassLoader()
private val replClassLoader = addReplClassLoaderIfNeeded(urlClassLoader)
+ // One thread will handle loading all of the plugins on this executor
--- End diff --
I guess it could be in the constructor; `Utils.loadExtensions` already
provides a `SparkConf` to the constructor if one accepts it, which was the only
thing I could think of.
I generally dislike plugin APIs that encourage initialization in the
constructor, but here, other than maybe potentially some benefit for testing,
I'm not seeing a lot of differences in not having the init method after all...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
