Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22192#discussion_r213821674
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -130,6 +130,14 @@ private[spark] class Executor(
       private val urlClassLoader = createClassLoader()
       private val replClassLoader = addReplClassLoaderIfNeeded(urlClassLoader)
     
    +  // Load plugins in the current thread, they are expected to not block.
    +  // Heavy computation in plugin initialization should be done async.
    +  Thread.currentThread().setContextClassLoader(replClassLoader)
    +  conf.get(EXECUTOR_PLUGINS).foreach { classes =>
    --- End diff --
    
    Gets mad how? A default of `Nil` should still create a config constant that 
returns a `Seq[String]`, right?
    
    (I know I added the other configs that use this and they are optional 
instead of having a default value, but I'm kinda wondering what is the issue 
you're referring to.)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to