Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22270#discussion_r214564426
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -85,12 +85,12 @@ class DataFrameFunctionsSuite extends QueryTest with 
SharedSQLContext {
         }
     
         val df5 = Seq((Seq("a", null), Seq(1, 2))).toDF("k", "v")
    -    intercept[RuntimeException] {
    +    intercept[Exception] {
    --- End diff --
    
    Shall we also catch specific exception per 
https://github.com/databricks/scala-style-guide#testing-intercepting


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to