Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22263#discussion_r225005803
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -288,6 +297,69 @@ class CachedTableSuite extends QueryTest with 
SQLTestUtils with SharedSQLContext
         }
       }
     
    +  test("SQL interface support storageLevel(DISK_ONLY)") {
    +    sql("CACHE TABLE testData OPTIONS('storageLevel' 'DISK_ONLY')")
    +    assertCached(spark.table("testData"))
    +    val rddId = rddIdOf("testData")
    +    assert(isExpectStorageLevel(rddId, Disk))
    +    assert(!isExpectStorageLevel(rddId, Memory))
    --- End diff --
    
    Do we need line 305 when we have line 304?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to