Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3009#discussion_r20665049
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -166,6 +188,21 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener with Logging {
trimJobsIfNecessary(failedJobs)
jobData.status = JobExecutionStatus.FAILED
}
+ for (stageId <- jobData.stageIds) {
+ stageIdToActiveJobIds.get(stageId).foreach { jobsUsingStage =>
+ jobsUsingStage.remove(jobEnd.jobId)
+ stageIdToInfo.get(stageId).foreach { stageInfo =>
+ // If this is a pending stage and no other job depends on it,
then it won't be run.
+ // To prevent memory leaks, remove this data since it won't be
cleaned up as stages
+ // finish / fail:
+ if (stageInfo.submissionTime.isEmpty &&
stageInfo.completionTime.isEmpty
+ && jobsUsingStage.isEmpty) {
--- End diff --
this looks funky, can you do it like this
```
if (stageInfo.submissionTime.isEmpty &&
stageInfo.completionTime.isEmpty &&
jobsUsingStage.isEmpty) {
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
