Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3009#discussion_r20665341
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
    @@ -214,6 +264,14 @@ class JobProgressListener(conf: SparkConf) extends 
SparkListener with Logging {
     
         val stages = poolToActiveStages.getOrElseUpdate(poolName, new 
HashMap[Int, StageInfo])
         stages(stage.stageId) = stage
    +
    +    for (
    +      activeJobsDependentOnStage <- 
stageIdToActiveJobIds.get(stage.stageId);
    +      jobId <- activeJobsDependentOnStage;
    +      jobData <- jobIdToData.get(jobId)
    +    ) {
    +      jobData.numActiveStages += 1
    +    }
    --- End diff --
    
    Ok I realized what this is (the apparent-hang behavior we discussed) -- but 
it would be great to add a comment somewhere describing this (maybe in 
JobUIData, explaining why completedStages is a set?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to