mgaido91 commented on a change in pull request #23384: [SPARK-26443 ][CORE] Use
ConfigEntry for hardcoded configs for history category.
URL: https://github.com/apache/spark/pull/23384#discussion_r244308645
##########
File path: core/src/main/scala/org/apache/spark/internal/config/History.scala
##########
@@ -29,6 +29,14 @@ private[spark] object History {
.stringConf
Review comment:
not related to this PR, but `EVENT_LOG_DIR` doesn't seem a great name to me
for this property, as we have a `spark.eventLog.dir`. Shall we update it to
`HISTORY_LOG_DIR` or something similar in order to disambiguate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
