mgaido91 commented on a change in pull request #23413:
[SPARK-26491][CORE][TEST] Use ConfigEntry for hardcoded configs for test
categories
URL: https://github.com/apache/spark/pull/23413#discussion_r244970655
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -267,7 +268,7 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
}
// Disable the background thread during tests.
- if (!conf.contains("spark.testing")) {
+ if (!conf.contains(IS_TESTING)) {
Review comment:
I don't think so, here we are checking the `SparkConf`, while in
`Utils.isTesting` we check the system properties. So I don't think it is doable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
