mgaido91 commented on a change in pull request #23413:
[SPARK-26491][CORE][TEST] Use ConfigEntry for hardcoded configs for test
categories
URL: https://github.com/apache/spark/pull/23413#discussion_r244970983
##########
File path: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
##########
@@ -202,7 +203,7 @@ class TaskMetrics private[spark] () extends Serializable {
}
// Only used for test
- private[spark] val testAccum = sys.props.get("spark.testing").map(_ => new
LongAccumulator)
+ private[spark] val testAccum = sys.props.get(IS_TESTING.key).map(_ => new
LongAccumulator)
Review comment:
I agree it is doable but the code would become an if which seems to me less
clean than the current code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
