HeartSaVioR commented on a change in pull request #23423: [SPARK-26482][CORE]
Use ConfigEntry for hardcoded configs for ui categories
URL: https://github.com/apache/spark/pull/23423#discussion_r245204562
##########
File path: core/src/main/scala/org/apache/spark/ui/SparkUI.scala
##########
@@ -151,12 +152,11 @@ private[spark] abstract class SparkUITab(parent:
SparkUI, prefix: String)
}
private[spark] object SparkUI {
- val DEFAULT_PORT = 4040
val STATIC_RESOURCE_DIR = "org/apache/spark/ui/static"
val DEFAULT_POOL_NAME = "default"
def getUIPort(conf: SparkConf): Int = {
- conf.getInt("spark.ui.port", SparkUI.DEFAULT_PORT)
+ conf.get(UI_PORT)
Review comment:
Yes it is only used for default value on configuration for `UI_PORT` at
least in Spark codebase, so I guess it can be removed once `UI_PORT` has
default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
