HeartSaVioR commented on a change in pull request #23423: [SPARK-26482][CORE]
Use ConfigEntry for hardcoded configs for ui categories
URL: https://github.com/apache/spark/pull/23423#discussion_r245204864
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -724,13 +709,44 @@ package object config {
.checkValue(v => v > 0, "The max failures should be a positive value.")
.createWithDefault(40)
- private[spark] val EXECUTOR_PLUGINS =
- ConfigBuilder("spark.executor.plugins")
- .doc("Comma-separated list of class names for \"plugins\" implementing "
+
- "org.apache.spark.ExecutorPlugin. Plugins have the same privileges as
any task " +
- "in a Spark executor. They can also interfere with task execution and
fail in " +
- "unexpected ways. So be sure to only use this for trusted plugins.")
- .stringConf
- .toSequence
- .createWithDefault(Nil)
+ private[spark] val EXECUTOR_PLUGINS = ConfigBuilder("spark.executor.plugins")
+ .doc("Comma-separated list of class names for \"plugins\" implementing " +
+ "org.apache.spark.ExecutorPlugin. Plugins have the same privileges as
any task " +
+ "in a Spark executor. They can also interfere with task execution and
fail in " +
+ "unexpected ways. So be sure to only use this for trusted plugins.")
+ .stringConf
+ .toSequence
+ .createWithDefault(Nil)
+
+ private[spark] val MASTER_REST_SERVER_ENABLED =
ConfigBuilder("spark.master.rest.enabled")
Review comment:
I'm OK in either way. I might miss some more configurations on standalone
mode so we may have chance to move them in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
