cloud-fan commented on a change in pull request #23709: 
[SPARK-26794][SQL]SparkSession enableHiveSupport does not point to hive but 
in-memory while the SparkContext exists
URL: https://github.com/apache/spark/pull/23709#discussion_r252662471
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
 ##########
 @@ -165,8 +166,11 @@ object SharedState extends Logging {
 
   private val HIVE_EXTERNAL_CATALOG_CLASS_NAME = 
"org.apache.spark.sql.hive.HiveExternalCatalog"
 
-  private def externalCatalogClassName(conf: SparkConf): String = {
-    conf.get(CATALOG_IMPLEMENTATION) match {
+  private def externalCatalogClassName(
+      conf: SparkConf,
+      initSessionConfig: Map[String, String]): String = {
 
 Review comment:
   let's add a comment to say that `initSessionConfig` has high priority 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to