cloud-fan commented on a change in pull request #23709:
[SPARK-26794][SQL]SparkSession enableHiveSupport does not point to hive but
in-memory while the SparkContext exists
URL: https://github.com/apache/spark/pull/23709#discussion_r252664065
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -40,7 +40,8 @@ import org.apache.spark.util.{MutableURLClassLoader, Utils}
/**
* A class that holds all state shared across sessions in a given
[[SQLContext]].
*/
-private[sql] class SharedState(val sparkContext: SparkContext) extends Logging
{
+private[sql] class SharedState(val sparkContext: SparkContext, initConfig:
Map[String, String])
Review comment:
it seems we get 2 kinds of configs from `sparkContext`: `SparkConf` and
hadoop `Configuration`. Maybe we can do
```
val conf = sparkContext.conf.clone()
val hadoopConf = sparkContext.hadoopConf.clone()
initConfig.foreach {
// set conf and hadoopConf
}
```
Then we just use `conf` and `hadoopConf` in `SharedState`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
