cloud-fan commented on a change in pull request #23709:
[SPARK-26794][SQL]SparkSession enableHiveSupport does not point to hive but
in-memory while the SparkContext exists
URL: https://github.com/apache/spark/pull/23709#discussion_r252923955
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -36,29 +36,41 @@ import org.apache.spark.sql.internal.StaticSQLConf._
import org.apache.spark.status.ElementTrackingStore
import org.apache.spark.util.{MutableURLClassLoader, Utils}
-
/**
* A class that holds all state shared across sessions in a given
[[SQLContext]].
*/
-private[sql] class SharedState(val sparkContext: SparkContext) extends Logging
{
+private[sql] class SharedState(val sparkContext: SparkContext, initConfig:
Map[String, String])
+ extends Logging {
+ private val conf = sparkContext.conf.clone()
+ private val hadoopConf = new Configuration(sparkContext.hadoopConfiguration)
Review comment:
this is more code, I think the current one is good enough. These 2 configs
are mutable and we don't need to pretend that they are not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
