HeartSaVioR commented on a change in pull request #23743: [SPARK-26843][MESOS]
Use ConfigEntry for hardcoded configs for "mesos" resource manager
URL: https://github.com/apache/spark/pull/23743#discussion_r254980264
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
##########
@@ -34,11 +34,11 @@ import org.apache.spark.internal.Logging
*/
private[mesos] object MesosSchedulerBackendUtil extends Logging {
/**
- * Parse a comma-delimited list of volume specs, each of which
+ * Parse a list of volume specs, each of which
* takes the form [host-dir:]container-dir[:rw|:ro].
*/
- def parseVolumesSpec(volumes: String): List[Volume] = {
- volumes.split(",").map(_.split(":")).flatMap { spec =>
+ def parseVolumesSpec(volumes: Seq[String]): List[Volume] = {
Review comment:
TBH I'm not sure we're requiring to mention every incompatible changes for
non-public API, but I'm not strongly against it. I'll add it to the PR
description.
Please consider that dealing with arbitrary reviewers who have different
views on reviewing is not easy. Similar change was done in other PR without any
mention and comment. I'd be happy if we have some rules/policies which are
across the community in project, and if it doesn't fall into the case, ideally
I'd like to see reviewers just kindly and politely suggest/ask it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
