HeartSaVioR commented on a change in pull request #23743: [SPARK-26843][MESOS]
Use ConfigEntry for hardcoded configs for "mesos" resource manager
URL: https://github.com/apache/spark/pull/23743#discussion_r255356941
##########
File path:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosFineGrainedSchedulerBackendSuite.scala
##########
@@ -80,9 +81,9 @@ class MesosFineGrainedSchedulerBackendSuite
}
test("Use configured mesosExecutor.cores for ExecutorInfo") {
- val mesosExecutorCores = 3
+ val mesosExecutorCores = 3.0
Review comment:
The type of EXECUTOR_CORES is actually `double` instead of `int` or `long`
and if my memory is right compiler complained. If we don't want to touch this
we may need to change below line to `conf.set(EXECUTOR_CORES.key,
mesosExecutorCores.toString)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
