HeartSaVioR commented on a change in pull request #23743: [SPARK-26843][MESOS]
Use ConfigEntry for hardcoded configs for "mesos" resource manager
URL: https://github.com/apache/spark/pull/23743#discussion_r255071404
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
##########
@@ -34,11 +34,11 @@ import org.apache.spark.internal.Logging
*/
private[mesos] object MesosSchedulerBackendUtil extends Logging {
/**
- * Parse a comma-delimited list of volume specs, each of which
+ * Parse a list of volume specs, each of which
* takes the form [host-dir:]container-dir[:rw|:ro].
*/
- def parseVolumesSpec(volumes: String): List[Volume] = {
- volumes.split(",").map(_.split(":")).flatMap { spec =>
+ def parseVolumesSpec(volumes: Seq[String]): List[Volume] = {
Review comment:
> My question was about the **mismatch** between PR title and content itself.
I didn't know the reason of the question, and `why` without reason behind
makes me feeling that I got non-positive reviews. I tried to find the reason
behind the comment, and thought you were concerning about method signature
change hence incompatible - turned out I was also wrong. We would have better
understanding of each other when we try to ensure explaining rationalization.
Btw, the rationalization of method signature change is follow: at the first
time I thought I have to add new methods with different signatures (maybe
overloaded) but another thought in my mind it would end up letting old methods
being not used anymore, and reviewers would ask me to remove them. So flatten
the steps into one would be changing signature anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
