dongjoon-hyun commented on a change in pull request #23743:
[SPARK-26843][MESOS] Use ConfigEntry for hardcoded configs for "mesos" resource
manager
URL: https://github.com/apache/spark/pull/23743#discussion_r255002997
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
##########
@@ -56,6 +56,26 @@ package object config {
.createOptional
}
+ private[spark] val CREDENTIAL_PRINCIPAL =
+ ConfigBuilder("spark.mesos.principal")
Review comment:
Do you think we had better have `.doc` like the previous conf
SECRET_FILENAMES at line 50 ~ 56?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
