dongjoon-hyun commented on a change in pull request #23743:
[SPARK-26843][MESOS] Use ConfigEntry for hardcoded configs for "mesos" resource
manager
URL: https://github.com/apache/spark/pull/23743#discussion_r255011395
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
##########
@@ -76,15 +76,14 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
cores - (cores % minCoresPerExecutor)
}
- private val useFetcherCache =
conf.getBoolean("spark.mesos.fetcherCache.enable", false)
+ private val useFetcherCache = conf.get(ENABLE_FETCHER_CACHE)
- private val maxGpus = conf.getInt("spark.mesos.gpus.max", 0)
+ private val maxGpus = conf.get(MAX_GPUS)
- private val taskLabels = conf.get("spark.mesos.task.labels", "")
+ private val taskLabels = conf.get(TASK_LABELS)
private[this] val shutdownTimeoutMS =
- conf.getTimeAsMs("spark.mesos.coarse.shutdownTimeout", "10s")
- .ensuring(_ >= 0, "spark.mesos.coarse.shutdownTimeout must be >= 0")
+ conf.get(COARSE_SHUTDOWN_TIMEOUT).ensuring(_ >= 0,
s"$COARSE_SHUTDOWN_TIMEOUT must be >= 0")
Review comment:
Since we have `checkValue` in config definition, we can remove this
`ensuring` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
