dongjoon-hyun commented on a change in pull request #23743:
[SPARK-26843][MESOS] Use ConfigEntry for hardcoded configs for "mesos" resource
manager
URL: https://github.com/apache/spark/pull/23743#discussion_r255011165
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
##########
@@ -118,6 +143,140 @@ package object config {
.stringConf
.createWithDefault("")
+ private[spark] val DRIVER_FRAMEWORK_ID =
+ ConfigBuilder("spark.mesos.driver.frameworkId")
+ .stringConf
+ .createOptional
+
private[spark] val EXECUTOR_URI =
ConfigBuilder("spark.executor.uri").stringConf.createOptional
+
+ private[spark] val PROXY_BASE_URL =
+ ConfigBuilder("spark.mesos.proxy.baseURL").stringConf.createOptional
+
+ private[spark] val COARSE_MODE =
+ ConfigBuilder("spark.mesos.coarse").booleanConf.createWithDefault(true)
+
+ private[spark] val COARSE_SHUTDOWN_TIMEOUT =
+ ConfigBuilder("spark.mesos.coarse.shutdownTimeout")
+ .timeConf(TimeUnit.MILLISECONDS)
Review comment:
Let's add `.checkValue(_ >= 0, s"spark.mesos.coarse.shutdownTimeout must be
>= 0")` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
