squito commented on a change in pull request #23767: [SPARK-26329][CORE][WIP]
Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r258655046
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala
##########
@@ -218,9 +218,7 @@ class ReplayListenerSuite extends SparkFunSuite with
BeforeAndAfter with LocalSp
// Verify the same events are replayed in the same order
assert(sc.eventLogger.isDefined)
- val originalEvents = sc.eventLogger.get.loggedEvents.filter { e =>
-
!JsonProtocol.sparkEventFromJson(e).isInstanceOf[SparkListenerStageExecutorMetrics]
- }
+ val originalEvents = sc.eventLogger.get.loggedEvents
Review comment:
@edwinalu can you remind us what the point of this old filter was?
I know it had something to do with not logging every event, only the
aggregated ones, to keep event logs small, but forget the details. @wypoon can
you explain why it needed to change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
