squito commented on a change in pull request #23767: [SPARK-26329][CORE][WIP]
Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r258652769
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -903,7 +905,7 @@ private[spark] class TaskSetManager(
isZombie = true
}
- sched.dagScheduler.taskEnded(tasks(index), reason, null, accumUpdates,
info)
+ sched.dagScheduler.taskEnded(tasks(index), reason, null, accumUpdates,
metricPeaks, info)
Review comment:
as I mentioned elsewhere, we could actually get metrics here and make the
same updates
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
