squito commented on a change in pull request #23767: [SPARK-26329][CORE][WIP]
Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r258628876
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -189,9 +203,44 @@ private[spark] class Executor(
*/
private val HEARTBEAT_INTERVAL_MS = conf.get(EXECUTOR_HEARTBEAT_INTERVAL)
+ /**
+ * Interval to poll for executor metrics, in milliseconds
+ */
+ private val METRICS_POLLING_INTERVAL_MS =
conf.get(EXECUTOR_METRICS_POLLING_INTERVAL)
+
+ // Executor for the metrics polling task
+ private val poller =
+ if (METRICS_POLLING_INTERVAL_MS > 0) {
+ ThreadUtils.newDaemonSingleThreadScheduledExecutor("executor-poller")
Review comment:
unfortunately, it does not eliminate concurrency considerations -- if we're
sending the metrics in the task end, then we also need to get them from the
task-runner thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
