vanzin commented on a change in pull request #23156: [SPARK-24063][SS] Add maximum epoch queue threshold for ContinuousExecution URL: https://github.com/apache/spark/pull/23156#discussion_r259138736
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala ########## @@ -60,6 +60,10 @@ class ContinuousExecution( // For use only in test harnesses. private[sql] var currentEpochCoordinatorId: String = _ + // Throwable that caused the execution to fail + private var failure: Option[Throwable] = None Review comment: Couldn't you just use an `AtomicReference` here instead of Option + lock? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
